Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use python sets #158

Closed
wants to merge 1 commit into from
Closed

Use python sets #158

wants to merge 1 commit into from

Conversation

blag
Copy link

@blag blag commented May 22, 2014

Instead of

for (loop):
    if (condition):
        continue

simply use Python sets:

for attr in set(attrs.keys()).intersection(set(self.attr_val_is_uri)):
    ...

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/1615

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@gsnedders
Copy link
Member

Can you have each branch based on upstream master, so you don't have massive overlap between PRs? Note that #110 makes large changes to the sanitizer — including changing the lists to sets.

@blag
Copy link
Author

blag commented May 29, 2014

Sorry I'm still new to using Github's pull requests. This is fixed.

And yes, this is superseded by #110.

@gsnedders
Copy link
Member

Per above, superseded.

@gsnedders gsnedders closed this Jul 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blag @hoppipolla-critic-bot @gsnedders